Jonathan/Babushka
2
0
Fork 0
Code Pull Requests 1 Releases Activity

feature/events #19

Merged
Jonathan merged 10 commits from feature/events into develop 2025-10-28 21:12:46 +01:00
Conversation 2 Commits 10 Files Changed 30
+572 -32
kziolkowski commented 2025-10-21 12:43:50 +02:00
Owner
Copy Link
Copy Source

Created a new resource class called EventResource that can be used to signal events and store values outside of scenes.
The Payload is stored as a Godot Variant and can be used for all kinds of typed functions.
I also added active event raising passive onvaluechange-events with old and new payloads.
You can check out a sample scene under scenes/testing/EventTest.

Created a new resource class called EventResource that can be used to signal events and store values outside of scenes. The Payload is stored as a Godot Variant and can be used for all kinds of typed functions. I also added active event raising passive onvaluechange-events with old and new payloads. You can check out a sample scene under scenes/testing/EventTest.
Jonathan was assigned by kziolkowski 2025-10-21 12:43:50 +02:00
kziolkowski added 39 commits 2025-10-21 12:43:51 +02:00
changes after develop merge c2f5359d0c
Added word wrapping to quest post it. 96c7d35aa7
Fixed tool animation 41365fb5d4
WIP moving seed to plant matching into separate system, making fields independent of specific plants. ce2d7eb773
Fixed tomato farming again 7fd26ffed3
planting, growing and watering a little less dependent than before d0ba4076b3
re-added watering animation and vfx 36c948f116
changed watering can display to slider 7c03964d33
Added interaction on mouse click 283caf282b
Reinstated plantgrowing animation 5992c390ee
Added option to play pickup animation for non-inventory items 4734ae953c
Added Hotkey-Info to inventory prefab 3913143892
Implemented first version of an interactable area that reacts to inventory selection 6ae877f2ab
minor scene fixes f6e0c4e615
Implemented PR feedback + made sure initial farming quests run smoothly 378bf45c49
Tools get deactivated from animation when switching to an empty slot in the inventory. Also fixed layering (AGAIN) 871e1856f1
Added possibility to deactivate an interactionarea if there is no more timelines to play eeb56fd7ad
Added Single Footstep SFX, added folders and moved files for better organization 8f3be823a4
SFX Footstep Gravel Added 6f340b54a4
Merge remote-tracking branch 'origin/Nao's-Sounds' into feature/showcase_bugfixing_kathi_partII 89313fd484
Added Footsteps SFX e44e06bace
Added typing sounds to dialogic characters 652cac4232
WIP trying to implement pickup sounds 9f50e1d293
WIP reworking the item repository d1a8ff0cbf
fixed item repository bug 975dd45c94
Fixed Tomato farming (again) 2cb605261e
grass layering fix 06fd80f762
Added beetroot as growable plant 1f88f9b4b5
Set up second garden with beetroot, built transition from yard and back c56f654751
Fixed InventoryInstance behaviour 0713e334b3
🎨 💄 Created art template for farm plants and reworked existing plant prefabs and inventory resources e73f13d7d4
💄 updated dialogic style to make it clearer who is talking and have vesna always on the left side 936983e14f
🐛 fixed ducks counting bug d6a2b586e4
Implemented first version of EventResources 1e004b62b8
📝 added documentation and improved event scope a593be8273
Godot upgrade to 4.5 a74abe684b
created test scene and removed event test elements from start scene 5bcbee8865
✨ Added event payload and Valuechange-handling ef56f79d5c
✨ Added randomizer class for certain types of EventResources 5cf250b295
kziolkowski added 1 commit 2025-10-21 12:51:03 +02:00
removed redundant import statement 080ebaae47
kziolkowski self-assigned this 2025-10-24 16:05:57 +02:00
kziolkowski requested review from Jonathan 2025-10-24 16:06:02 +02:00
Jonathan was unassigned by kziolkowski 2025-10-24 16:06:07 +02:00
Jonathan requested changes 2025-10-27 18:47:02 +01:00
Jonathan left a comment
Owner
Copy Link
Copy Source

Ich verstehe nicht, wie Payload verwendet werden soll, bzw. was die Idee hinter der Implementierung ist. @kziolkowski Können wir da noch einmal drüber sprechen?

Ich verstehe nicht, wie Payload verwendet werden soll, bzw. was die Idee hinter der Implementierung ist. @kziolkowski Können wir da noch einmal drüber sprechen?
scripts/CSharp/Low Code/Events/EventListener.cs Outdated
@@ -0,0 +75,4 @@
public void EventInvoked(Variant payload)
{
if(_showLog)
GD.Print("Event Raised on: " + Name);
Jonathan commented 2025-10-27 18:36:12 +01:00
Owner
Copy Link
Copy Source

Debug logs bitte noch entfernen

Debug logs bitte noch entfernen
kziolkowski commented 2025-10-28 11:01:25 +01:00
Author
Owner
Copy Link
Copy Source

An sich stimme ich dir zu, aber diese habe ich mit Absicht drin gelassen und hinter einem bool versteckt, weil ich die Erfahrung gemacht habe, dass man diese Debugs relativ häufig braucht, wenn man mit Events und Variablen arbeitet.

An sich stimme ich dir zu, aber diese habe ich mit Absicht drin gelassen und hinter einem bool versteckt, weil ich die Erfahrung gemacht habe, dass man diese Debugs relativ häufig braucht, wenn man mit Events und Variablen arbeitet.
scripts/CSharp/Low Code/Events/EventListener.cs Outdated
@@ -0,0 +87,4 @@
public void EventPayloadChanged(Variant payload, Variant oldPayload)
{
if(_showLog)
GD.Print($"Calling Event Payload Changed Signals on: " + Name);
Jonathan commented 2025-10-27 18:36:23 +01:00
Owner
Copy Link
Copy Source

Debug logs bitte noch entfernen

Debug logs bitte noch entfernen
kziolkowski marked this conversation as resolved
scripts/CSharp/Low Code/Events/EventRaiser.cs Outdated
@@ -0,0 +28,4 @@
/// Raises <see cref="EventResource"/> at index.
/// </summary>
/// <param name="index"></param>
public void RaiseEvent(int index)
Jonathan commented 2025-10-27 18:29:40 +01:00
Owner
Copy Link
Copy Source

Sollte nicht existieren. Es gibt keinen guten Grund, warum man das aufrufen sollte. Wenn man zwei verschiedene Events separat voneinander raisen will, sollte man ohnehin zwei Event Raiser benutzen.

Sollte nicht existieren. Es gibt keinen guten Grund, warum man das aufrufen sollte. Wenn man zwei verschiedene Events separat voneinander raisen will, sollte man ohnehin zwei Event Raiser benutzen.
kziolkowski marked this conversation as resolved
kziolkowski added 3 commits 2025-10-28 13:09:44 +01:00
✨ Separated events from variables and adjusted test scene c96e6da78e
🔥 removed indexed RaiseEvent-Call from EventRaiser 8c1157c26e
✨ Added VariableGetter functionality and some Variable setting components. Also added them to test scene. 3fe79f2fd8
Jonathan approved these changes 2025-10-28 19:42:24 +01:00
Jonathan merged commit afce4ad0b9 into develop 2025-10-28 21:12:46 +01:00
Sign in to join this conversation.
Reviewers
No Reviewers
Jonathan
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
ascheck (Anna Scheck) jlink kziolkowski (Katharina Ziolkowski) lkrause Nao Palurdas saderako Sanelschnitte Jonathan
No Assignees kziolkowski
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Jonathan/Babushka#19
Delete Branch "feature/events"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?