Jonathan/Babushka
2
0
Fork 0
Code Pull Requests 1 Releases Activity

feature/showcase_bugfixing_kathi #14

Merged
Jonathan merged 20 commits from feature/showcase_bugfixing_kathi into develop 2025-08-06 18:16:55 +02:00
Conversation 1 Commits 20 Files Changed 100
+850 -450
kziolkowski commented 2025-08-02 17:24:21 +02:00
Owner
Copy Link
Copy Source

Part one of integrating bugfixes after the IGF showcase:

  • item interactions:

    • Interaction Area 2D now works with an outline material and a label. Created a separate PR for this: #13
    • added second outline color to differentiate simple interactions (yellow) from inventory item interactions (orange)
      imageimage
    • fixed layering issues in farm outside and common room scene
    • dialogic:
      • increased global font size
      • made text left-bound
      • made answer options more visible
      • deactivated animated characters in the scene during dialogues
      • removed vesna2 character and replaced it with vesna
        image
    • fixed vesna's movement sothat it looks more like walking and less like gliding
Part one of integrating bugfixes after the IGF showcase: * item interactions: - Interaction Area 2D now works with an outline material and a label. Created a separate PR for this: http://h2996454.stratoserver.net:3000/Jonathan/Babushka/pulls/13 - added second outline color to differentiate simple interactions (yellow) from inventory item interactions (orange) ![image](/attachments/5f46a355-3d49-41e4-852a-097f03fd85aa)![image](/attachments/67006655-c0ca-4380-a906-a1b8e3376e3c) * fixed layering issues in farm outside and common room scene * dialogic: - increased global font size - made text left-bound - made answer options more visible - deactivated animated characters in the scene during dialogues - removed vesna2 character and replaced it with vesna ![image](/attachments/b070408a-ab0e-4052-862f-8a60d317fdd8) * fixed vesna's movement sothat it looks more like walking and less like gliding
image.png
319 KiB
image.png
321 KiB
image.png
1.9 MiB
kziolkowski added 20 commits 2025-08-02 17:24:21 +02:00
Fixed farming (the way it was before) d2c7302ab2
Removed no longer needed print statements b92eb909ad
WIP trying to fix the last plant stage bug on repeated farming rounds 486cfb5546
Fixed ysorting on ducks and trash ab23d41496
Fixed Yeli Layering issue in indoor scene 5ee295256b
wip exchanging interaction label with outline ad16b86171
set duck body scale to 1,1 cfe604d3b7
Extracted FightAttack Enum in the hopes of fixing errors 730c4999d7
Removed disclaimer reference from bootstrap 19e30dd0b8
Added Wellbehaviour and fixed door interaction to offer outlines 0f246825fc
Fixed output error ERROR: Script class can only be set together with base class name 18711776bb
cleaned up dialogue structure and removed vesna2 from dialogues f01143e887
Updated interaction area setups to avoid nullrefs e88ba2e1ef
Fixed dialogic settings 279cac22ee
MAde Vesna and Yeli disappear on dialogic start 6275bea52c
Added secondary outline mat and assigned it to inventory items 8f75b5b644
fixed pickup layering b69191e7f7
Made sure splash screen features logo 2e21fb7e98
Vesna can walk diagonally now 8e0dced918
Adjusted moving values and animations to make vesna not slide any more 0008b16d48
Jonathan was assigned by kziolkowski 2025-08-02 17:24:34 +02:00
Jonathan was unassigned by kziolkowski 2025-08-02 17:24:54 +02:00
kziolkowski requested review from Jonathan 2025-08-02 17:25:00 +02:00
Jonathan approved these changes 2025-08-06 18:00:33 +02:00
scripts/CSharp/Common/CharacterControls/PlayerMovement.cs
@@ -0,0 +53,4 @@
if (anyActionPressed)
{
if (currentVelocity.X != 0 && currentVelocity.Y != 0)
Jonathan commented 2025-08-06 17:56:03 +02:00
Owner
Copy Link
Copy Source

Never compare floating point numbers by == or !=

Maybe use instead:

if (currentVelocity.LengthSquared() > _speed * _speed)
{
    currentVelocity = currentVelocity.Normalized() * _speed;
}
Never compare floating point numbers by `==` or `!=` Maybe use instead: ``` if (currentVelocity.LengthSquared() > _speed * _speed) { currentVelocity = currentVelocity.Normalized() * _speed; } ```
Jonathan merged commit 9253a78a06 into develop 2025-08-06 18:16:55 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
Jonathan
Labels
No items
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
ascheck (Anna Scheck) jlink kziolkowski (Katharina Ziolkowski) lkrause Nao Palurdas saderako Sanelschnitte Jonathan
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Jonathan/Babushka#14
Delete Branch "feature/showcase_bugfixing_kathi"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?